test: move test-benchmark-buffer to sequential#15373
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: move test-benchmark-buffer to sequential#15373Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS. Move the test to `sequential` so it is not competing with other tests for resources. Fixes: nodejs#15372
cjihrig
approved these changes
Sep 12, 2017
BridgeAR
approved these changes
Sep 12, 2017
mscdex
added
benchmark
evanlucas
approved these changes
Sep 12, 2017
refack
approved these changes
Sep 12, 2017
3 tasks
Member
Author
|
Stress test (started by @mscdex) to see if it's not a problem with the test itself: https://ci.nodejs.org/job/node-stress-single-test/1409/ If that stress test comes back green, that would suggest that moving the test to If that stress test comes back red, that would suggest that moving the test to |
hiroppy
approved these changes
Sep 13, 2017
jasnell
approved these changes
Sep 13, 2017
Contributor
|
Cross-ref: https://ci.nodejs.org/job/node-stress-single-test/1409/ was stopped after 19h (OK: 1934 NOT OK: 0). I'd say it's stable on it's own. |
Member
|
This needs a rebase. |
Member
|
..nvm .. I rebased on landing... |
jasnell
pushed a commit
that referenced
this pull request
Sep 14, 2017
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS. Move the test to `sequential` so it is not competing with other tests for resources. PR-URL: #15373 Fixes: #15372 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in 082c434 |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS. Move the test to `sequential` so it is not competing with other tests for resources. PR-URL: nodejs/node#15373 Fixes: nodejs/node#15372 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2017
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS. Move the test to `sequential` so it is not competing with other tests for resources. PR-URL: #15373 Fixes: #15372 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS. Move the test to `sequential` so it is not competing with other tests for resources. PR-URL: nodejs/node#15373 Fixes: nodejs/node#15372 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-benchmark-bufferhas been observed to timeout on CI on SmartOS.Move the test to
sequentialso it is not competing with other testsfor resources.
Fixes: #15372
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test benchmark buffer