Skip to content

build: for --enable-static, run only cctest #14892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 3 commits into from
+11 −2
Closed

build: for --enable-static, run only cctest #14892

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1f1e88
build: for --enable-static, run only cctest
danbev Aug 17, 2017
c9ef989
squash: same logic for windows build
danbev Aug 21, 2017
a159bfa
[suggestion] flipped if and skip jslint
refack Aug 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: same logic for windows build 
Running .\vcbuild.bat test static should now only run the cctest target.
  • Loading branch information
@danbev
danbev committed Aug 22, 2017
commit c9ef989483eda617486fef9eb7530c0a1134903b
7 changes: 4 additions & 3 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,9 +445,10 @@ if "%config%"=="Debug" set test_args=--mode=debug %test_args%
if "%config%"=="Release" set test_args=--mode=release %test_args%
echo running 'cctest %cctest_args%'
"%config%\cctest" %cctest_args%
call :run-python tools\test.py %test_args%
goto test-v8

if not defined enable_static (
call :run-python tools\test.py %test_args%
goto test-v8
)
:test-v8
if not defined custom_v8_test goto cpplint
call tools/test-v8.bat
Expand Down