src: replace assert with CHECK_LE in node_api.cc#14514
Merged
bnoordhuis merged 2 commits intonodejs:masterfrom Aug 7, 2017
Merged
src: replace assert with CHECK_LE in node_api.cc#14514bnoordhuis merged 2 commits intonodejs:masterfrom
bnoordhuis merged 2 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
addaleax
approved these changes
Jul 27, 2017
richardlau
approved these changes
Jul 27, 2017
cjihrig
approved these changes
Jul 27, 2017
tniessen
approved these changes
Jul 27, 2017
TimothyGu
approved these changes
Jul 28, 2017
jasnell
approved these changes
Jul 31, 2017
TimothyGu
suggested changes
Aug 1, 2017
Member
TimothyGu
left a comment
TimothyGu
left a comment
There was a problem hiding this comment.
Actually, I'm going to have renege on my LGTM earlier. This file is AFAIK shared with an outside project that don't have access to the internal CHECK macros. I remember @gabrielschulhof said this might not be true any more after #14217 (comment), but I'd like to block this first before confirmation that such change is acceptable.
/cc @nodejs/n-api
Member
|
@TimothyGu Actually the |
jasongin
approved these changes
Aug 1, 2017
TimothyGu
approved these changes
Aug 1, 2017
refack
approved these changes
Aug 2, 2017
PR-URL: nodejs#14514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nie�en <[email protected]>
PR-URL: nodejs#14514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nie�en <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Aug 7, 2017
PR-URL: #14514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nie�en <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Aug 7, 2017
PR-URL: #14514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nie�en <[email protected]>
Contributor
|
@bnoordhuis LTS? |
Member
Author
|
Won't hurt. |
Contributor
|
only one of these two changes apply to the branch. for the sake of simplicity I'm going to label this do not land. |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
PR-URL: nodejs#14514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nie�en <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
Backport-PR-URL: #19447 PR-URL: #14514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nie�en <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #14474 (comment), cc @ChALkeR
CI: https://ci.nodejs.org/job/node-test-pull-request/9373/