test,benchmark: stabilize child-process#13457
Merged
refack merged 1 commit intonodejs:masterfrom Jun 7, 2017
Merged
Conversation
Contributor
Author
tniessen
approved these changes
Jun 4, 2017
Member
There was a problem hiding this comment.
Just a suggestion, feel free to ignore: I would replace arguments with command lines as Windows does not really have a concept of arguments. You could even be more specific, Windows does not support command lines longer than 8191 characters (there is no reason to believe that Microsoft is going to raise that limit).
Contributor
Author
|
@nodejs/platform-windows @gireeshpunathil help me think about this |
Contributor
Author
|
Kill stress after 1000 good iterations. I call "stable". |
tniessen
approved these changes
Jun 4, 2017
Contributor
Author
also some cleanup PR-URL: nodejs#13457 Refs: nodejs#12817 Reviewed-By: Tobias Nießen <[email protected]>
b0fff66 to
8d2bd5f
Compare
Contributor
Author
|
Landed in 8d2bd5f |
Contributor
Author
addaleax
pushed a commit
that referenced
this pull request
Jun 10, 2017
also some cleanup PR-URL: #13457 Refs: #12817 Reviewed-By: Tobias Nießen <[email protected]>
Merged
3 tasks
Contributor
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also some cleanup
Ref: #12817
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test,benchmark