(v7.x-backport) build: enable cctest to use generated objects #12321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Contributor
Author
This was referenced Apr 11, 2017
Contributor
Author
|
Current CI failures are nodejs/build#681, nodejs/build#682 and #12104 (comment). |
Contributor
Author
|
All seems to be good except for a known issue for |
This commit tries to make it simpler to add unit tests (cctest) for code that needs to test node core funtionality but that might not be appropriate as an addon or a JavaScript test. An example of this could be adding functionality targeted for situations when Node itself is embedded. Currently it was not as easy, or efficient, as one would have hoped to add such tests. The object output directories vary for different operating systems which we need to link to so that we don't have an additional compilation step. PR-URL: nodejs#11956 Ref: nodejs#9163 Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#11956 Ref: nodejs#9163 Reviewed-By: James M Snell <[email protected]>
aqrln
force-pushed
the
backport-11956-to-v7.x
branch
from
5535847 to
2894692
Compare
Contributor
Author
|
Force-pushed with full original commit messages (no metadata removed). Ref: nodejs/Release#191 |
jasnell
approved these changes
Apr 13, 2017
evanlucas
approved these changes
May 2, 2017
Contributor
|
Landed in 75f0855. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #11956 to v7.x. PRs #12042 and #12238 (both labeled as "backport-to-v7.x") depend on it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build, doc