src: add missing #include <unicode/ustring.h>#11754
Merged
srl295 merged 0 commit intonodejs:masterfrom Mar 9, 2017
Merged
Conversation
nodejs-github-bot
added
c++
Member
Author
|
this fixes the node side. v8 side will have to be done upstream |
cjihrig
approved these changes
Mar 8, 2017
jasnell
approved these changes
Mar 9, 2017
TimothyGu
reviewed
Mar 9, 2017
Member
TimothyGu
left a comment
TimothyGu
left a comment
There was a problem hiding this comment.
Would be best if the commit message specifies which functions in ustring.h we are using right now.
Member
Author
|
@TimothyGu good idea, will do |
srl295
force-pushed
the
fix_include_ustring
branch
from
b013aa2 to
0543a78
Compare
Member
Author
|
@TimothyGu please re review |
Member
Author
|
v8 issue will be fixed in https://codereview.chromium.org/2738503008 (work in progress) It may be that other changes are needed as well, but this gets the immediate one. |
srl295
force-pushed
the
fix_include_ustring
branch
from
0543a78 to
4fb149d
Compare
srl295
force-pushed
the
fix_include_ustring
branch
from
4fb149d to
5efb15e
Compare
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 13, 2017
* We use these functions that are declared in <unicode/ustring.h>
u_strFromUTF8()
u_strToUTF8()
* At present, <unicode/ustring.h> is indirectly included, but this will
likely change in future ICUs. Adding this header has been the right
thing to do for many years, so it is backwards compatible.
Fixes: nodejs#11753
PR-URL: nodejs#11754
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
* We use these functions that are declared in <unicode/ustring.h>
u_strFromUTF8()
u_strToUTF8()
* At present, <unicode/ustring.h> is indirectly included, but this will
likely change in future ICUs. Adding this header has been the right
thing to do for many years, so it is backwards compatible.
Fixes: nodejs#11753
PR-URL: nodejs#11754
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Contributor
|
@srl295 should this be backported to v6.x? |
Contributor
|
ping |
Member
Author
|
@MylesBorins If the patch applies, it doesn't hurt to backport it. It improves future proofing if someone were to use a later ICU with v6.x. Short answer, yes I think it should be. |
Contributor
|
@srl295 it doesn't land cleanly, please feel free to backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #11753
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
i18n