inspector: no crash when WS server can't start#10878
Merged
eugeneo merged 1 commit intonodejs:masterfrom Jan 20, 2017
eugeneo:no-assert
Merged
inspector: no crash when WS server can't start#10878eugeneo merged 1 commit intonodejs:masterfrom eugeneo:no-assert
eugeneo merged 1 commit intonodejs:masterfrom
eugeneo:no-assert
Conversation
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Jan 18, 2017
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. This doesn't change the default behavior of binding to 127.0.0.1, does it?
Contributor
Author
|
@bnoordhuis - it will bind to 127.0.0.1 as per https://github.com/nodejs/node/blob/master/src/node_debug_options.cc#L62 - the fact that host was hardcoded was an oversight. |
jasnell
approved these changes
Jan 19, 2017
cjihrig
approved these changes
Jan 19, 2017
Contributor
Author
|
CI is green - https://ci.nodejs.org/job/node-test-pull-request/5939/ - even though the GitHub integration shows failure on ARM... |
This change also changes error message to make it consistent with the one printed by the debugger. Fixes: #10858 PR-URL: #10878 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Contributor
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/5957/ (all green, despite what GitHub shows) |
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
This change also changes error message to make it consistent with the one printed by the debugger. Fixes: #10858 PR-URL: #10878 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
This change also changes error message to make it consistent with the one printed by the debugger. Fixes: nodejs#10858 PR-URL: nodejs#10878 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
This change also changes error message to make it consistent with the one printed by the debugger. Fixes: nodejs#10858 PR-URL: nodejs#10878 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
|
A backport PR is required in order for this to land on v6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change also changes error message to make it consistent with the
one printed by the debugger.
Fixes: #10858
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
inspector: now it uses host name from the debug options. Messages were slightly altered.