-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
Make embedding + V8 inspector work again #17254
Copy link
Copy link
Closed
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.embeddingIssues and PRs related to embedding Node.js in another project.Issues and PRs related to embedding Node.js in another project.
Description
Metadata
Metadata
Assignees
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.embeddingIssues and PRs related to embedding Node.js in another project.Issues and PRs related to embedding Node.js in another project.
See #16981 (comment).
Commit 9e08695 removed all
v8::platform::PumpMessageLoop()calls from the code base.It's problematic for embedders like electron that plug in their own
v8::Platformbecause they now no longer get notifications from the V8 inspector.We should probably restore the
PumpMessageLoop()calls, even if they're no-ops in normal node builds.