Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v18.18.1
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v18.18.2
Choose a head ref
  • 12 commits
  • 58 files changed
  • 7 contributors

Commits on Oct 10, 2023

  1. Working on v18.18.2

    PR-URL: #50066
    richardlau committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b2b3118 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Revert "deps: update nghttp2 to 1.55.0"

    This reverts commit c8da8c8.
    
    PR-URL: #50151
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    richardlau committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7d83ed0 View commit details
    Browse the repository at this point in the history
  2. deps: update nghttp2 to 1.53.0

    PR-URL: #47997
    Backport-PR-URL: #50151
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    nodejs-github-bot authored and richardlau committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    300a902 View commit details
    Browse the repository at this point in the history
  3. deps: update nghttp2 to 1.55.0

    PR-URL: #48746
    Backport-PR-URL: #50151
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    nodejs-github-bot authored and richardlau committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    85672c1 View commit details
    Browse the repository at this point in the history
  4. deps: update nghttp2 to 1.55.1

    PR-URL: #48790
    Backport-PR-URL: #50151
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Yongsheng Zhang <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    nodejs-github-bot authored and richardlau committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7e9b08d View commit details
    Browse the repository at this point in the history
  5. deps: update nghttp2 to 1.56.0

    PR-URL: #49582
    Backport-PR-URL: #50151
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and richardlau committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    f6444de View commit details
    Browse the repository at this point in the history
  6. deps: update nghttp2 to 1.57.0

    PR-URL: #50121
    Backport-PR-URL: #50151
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    jasnell authored and richardlau committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    a792bbc View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. policy: use tamper-proof integrity check function

    Using the JavaScript Hash class is unsafe because its internals can be
    tampered with. In particular, an application can cause
    Hash.prototype.digest() to return arbitrary values, thus allowing to
    circumvent the integrity verification that policies are supposed to
    guarantee.
    
    Add and use a new C++ binding internalVerifyIntegrity() that (hopefully)
    cannot be tampered with from JavaScript.
    
    PR-URL: nodejs-private/node-private#462
    Backport-PR-URL: nodejs-private/node-private#493
    Reviewed-By: Rafael Gonzaga <[email protected]>
    CVE-ID: CVE-2023-38552
    tniessen authored and richardlau committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    1c53893 View commit details
    Browse the repository at this point in the history
  2. module: fix code injection through export names

    createDynamicModule() properly escapes import names, but not export
    names. In WebAssembly, any string is a valid export name. Importing a
    WebAssembly module that uses a non-identifier export name leads to
    either a syntax error in createDynamicModule() or to code injection,
    that is, to the evaluation of almost arbitrary JavaScript code outside
    of the WebAssembly module.
    
    To address this issue, adopt the same mechanism in createExport() that
    createImport() already uses. Add tests for both exports and imports.
    
    PR-URL: nodejs-private/node-private#461
    Backport-PR-URL: nodejs-private/node-private#490
    Reviewed-By: Rafael Gonzaga <[email protected]>
    CVE-ID: CVE-2023-39333
    tniessen authored and richardlau committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    eaf9083 View commit details
    Browse the repository at this point in the history
  3. lib: let deps require node prefixed modules

    fixup
    
    fixup
    
    PR-URL: #50047
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Zeyu "Alex" Yang <[email protected]>
    KhafraDev authored and richardlau committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    1193ca5 View commit details
    Browse the repository at this point in the history
  4. deps: update undici to v5.26.3

    Signed-off-by: Matteo Collina <[email protected]>
    PR-URL: #50153
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    CVE-ID: CVE-2023-45143
    mcollina authored and richardlau committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    5502846 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8a01b3d View commit details
    Browse the repository at this point in the history
Loading