Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e6b69b9418
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c9cf7c2780
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jun 30, 2017

  1. build,win: use latest installed VS by default 

    vcbuild.bat should detect what version of Visual Studio to use, it
should simply work without any parameter if any supported version is
installed. It should default to the latest version, to match the
behavior of `node-gyp`.

PR-URL: #13911
Fixes: #13641
Reviewed-By: Refael Ackermann <[email protected]>
    @joaocgreis
    joaocgreis committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    e783475 View commit details
    Browse the repository at this point in the history

  2. build,win: respect VS version for building addons 

    When building in machines with multiple versions of Visual Studio
installed, node-gyp should respect the vs2015/vs2017 arguments passed
to vcbuild.bat instead of relying on its own detection mechanism.

PR-URL: #13911
Reviewed-By: Refael Ackermann <[email protected]>
    @joaocgreis
    joaocgreis committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    c9cf7c2 View commit details
    Browse the repository at this point in the history
Loading