src: fix ThrowInvalidURL call in PathToFileURL

danielmbrasil · web-flow · commit fd453837ea39 · 2025-02-26T14:34:50.000Z
Replace `nullptr` with `std::nullopt` when calling `ThrowInvalidURL` in `PathToFileURL`. This ensures the function receives the correct argument type and aligns with the expected behavior. PR-URL: #57141 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me>
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -161,7 +161,7 @@ void BindingData::PathToFileURL(const FunctionCallbackInfo<Value>& args) {
       ada::parse<ada::url_aggregator>(EncodePathChars(input_str, os), nullptr);
 
   if (!out) {
-    return ThrowInvalidURL(realm->env(), input.ToStringView(), nullptr);
+    return ThrowInvalidURL(realm->env(), input.ToStringView(), std::nullopt);
   }
 
   if (os == OS::WINDOWS && args.Length() > 2 && !args[2]->IsUndefined())

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ void BindingData::PathToFileURL(const FunctionCallbackInfo<Value>& args) {`
`161`	`161`	`ada::parse<ada::url_aggregator>(EncodePathChars(input_str, os), nullptr);`
`162`	`162`
`163`	`163`	`if (!out) {`
`164`		`- return ThrowInvalidURL(realm->env(), input.ToStringView(), nullptr);`
	`164`	`+ return ThrowInvalidURL(realm->env(), input.ToStringView(), std::nullopt);`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`if (os == OS::WINDOWS && args.Length() > 2 && !args[2]->IsUndefined())`