File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -2264,15 +2264,6 @@ def configure_v8(o, configs):
22642264 o ['variables' ]['v8_enable_external_code_space' ] = 1 if options .enable_pointer_compression else 0
22652265 o ['variables' ]['v8_enable_31bit_smis_on_64bit_arch' ] = 1 if options .enable_pointer_compression else 0
22662266 o ['variables' ]['v8_enable_extensible_ro_snapshot' ] = 0
2267- # TODO(richardlau): Temporal objects in V8 currently reference a private
2268- # ICU header file and fail to compile with shared ICU or no ICU. For now,
2269- # if auto-detecting, warn and disable Temporal in those cases.
2270- # Refs: https://github.com/nodejs/node/issues/62676
2271- if (not options .v8_disable_temporal_support and not options .v8_enable_temporal_support ):
2272- match options .with_intl :
2273- case 'none' :
2274- warn ('Temporal support disabled when compiling without ICU' )
2275- options .v8_disable_temporal_support = True
22762267 o ['variables' ]['v8_enable_temporal_support' ] = 0 if options .v8_disable_temporal_support else 1
22772268 o ['variables' ]['v8_trace_maps' ] = 1 if options .trace_maps else 0
22782269 o ['variables' ]['v8_use_perfetto' ] = 1 if options .with_perfetto else 0
Original file line number Diff line number Diff line change @@ -6,13 +6,9 @@ if (!common.hasTemporal) {
66 common . skip ( 'Temporal is not enabled' ) ;
77}
88
9- // TODO(legendecas): bundle zoneinfo data for small ICU and without ICU builds.
10- if ( ! common . hasFullICU ) {
11- common . skip ( 'Time zone support unavailable when not built with full ICU' ) ;
12- }
13- // TODO(aduh95): fix zoneinfo support with system-icu.
14- if ( process . config . variables . icu_system ) {
15- common . skip ( 'Time zone support unavailable on --with-intl=system-icu builds' ) ;
9+ // TODO(legendecas): bundle zoneinfo data for small ICU.
10+ if ( globalThis . Intl && ! common . hasFullICU ) {
11+ common . skip ( 'Time zone support unavailable when built with small ICU' ) ;
1612}
1713
1814// Use globalThis.Temporal to workaround linter complaints.
You can’t perform that action at this time.
0 commit comments