test: performance, remove Popen(shell=True) on Win

refack · jasnell · commit f6ddbaff8afd · 2017-04-04T09:48:12.000-07:00
not needed according to official python docs - https://docs.python.org/2/library/subprocess.html#index-2 PR-URL: #12138 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/tools/test.py b/tools/test.py
@@ -617,7 +617,6 @@ def RunProcess(context, timeout, args, **rest):
   pty_out = rest.pop('pty_out')
 
   process = subprocess.Popen(
-    shell = utils.IsWindows(),
     args = popen_args,
     **rest
   )

Original file line number	Diff line number	Diff line change
`@@ -617,7 +617,6 @@ def RunProcess(context, timeout, args, **rest):`
`617`	`617`	`pty_out = rest.pop('pty_out')`
`618`	`618`
`619`	`619`	`process = subprocess.Popen(`
`620`		`- shell = utils.IsWindows(),`
`621`	`620`	`args = popen_args,`
`622`	`621`	`**rest`
`623`	`622`	`)`