lib: test_runner#mock:timers respeced timeout_max behaviour

badkeyy · marco-ippolito · commit f10857828f6e · 2025-01-24T22:17:32.000+01:00
PR-URL: #55375 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org>
diff --git a/lib/internal/test_runner/mock/mock_timers.js b/lib/internal/test_runner/mock/mock_timers.js
@@ -34,6 +34,8 @@ const {
   codes: { ERR_INVALID_STATE, ERR_INVALID_ARG_VALUE },
 } = require('internal/errors');
 
+const { TIMEOUT_MAX } = require('internal/timers');
+
 const PriorityQueue = require('internal/priority_queue');
 const nodeTimers = require('timers');
 const nodeTimersPromises = require('timers/promises');
@@ -284,6 +286,10 @@ class MockTimers {
   }
 
   #createTimer(isInterval, callback, delay, ...args) {
+    if (delay > TIMEOUT_MAX) {
+      delay = 1;
+    }
+
     const timerId = this.#currentTimer++;
     const opts = {
       __proto__: null,
diff --git a/test/parallel/test-runner-mock-timers.js b/test/parallel/test-runner-mock-timers.js
@@ -251,6 +251,22 @@ describe('Mock Timers Test Suite', () => {
           done();
         }), timeout);
       });
+
+      it('should change timeout to 1ms when it is >= 2 ** 31', (t) => {
+        t.mock.timers.enable({ apis: ['setTimeout'] });
+        const fn = t.mock.fn();
+        global.setTimeout(fn, 2 ** 31);
+        t.mock.timers.tick(1);
+        assert.strictEqual(fn.mock.callCount(), 1);
+      });
+
+      it('should change the delay to one if timeout < 0', (t) => {
+        t.mock.timers.enable({ apis: ['setTimeout'] });
+        const fn = t.mock.fn();
+        global.setTimeout(fn, -1);
+        t.mock.timers.tick(1);
+        assert.strictEqual(fn.mock.callCount(), 1);
+      });
     });
 
     describe('clearTimeout Suite', () => {
