Skip to content

Commit f0a8916

Browse files
committed
lib: add TLSSocket default error handler
This prevents the server from crashing due to an unhandled rejection when a TLSSocket connection is abruptly destroyed during initialization and the user has not attached an error handler to the socket. e.g: ```js const server = http2.createSecureServer({ ... }) server.on('secureConnection', socket => { socket.on('error', err => { console.log(err) }) }) ``` PR-URL: nodejs-private/node-private#750 Fixes: #44751 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=3262404 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> CVE-ID: CVE-2025-59465
1 parent b4b887c commit f0a8916

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

lib/internal/tls/wrap.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1251,6 +1251,7 @@ function tlsConnectionListener(rawSocket) {
12511251
socket[kErrorEmitted] = false;
12521252
socket.on('close', onSocketClose);
12531253
socket.on('_tlsError', onSocketTLSError);
1254+
socket.on('error', onSocketTLSError);
12541255
}
12551256

12561257
// AUTHENTICATION MODES

0 commit comments

Comments
 (0)