fs: close file descriptor of promisified truncate

joaocgreis · Trott · commit eadc3850fe49 · 2019-08-10T19:21:30.000-07:00
PR-URL: #28858 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -264,7 +264,8 @@ async function rename(oldPath, newPath) {
 }
 
 async function truncate(path, len = 0) {
-  return ftruncate(await open(path, 'r+'), len);
+  const fd = await open(path, 'r+');
+  return ftruncate(fd, len).finally(fd.close.bind(fd));
 }
 
 async function ftruncate(handle, len = 0) {

Original file line number	Diff line number	Diff line change
`@@ -264,7 +264,8 @@ async function rename(oldPath, newPath) {`
`264`	`264`	`}`
`265`	`265`
`266`	`266`	`async function truncate(path, len = 0) {`
`267`		`- return ftruncate(await open(path, 'r+'), len);`
	`267`	`+ const fd = await open(path, 'r+');`
	`268`	`+ return ftruncate(fd, len).finally(fd.close.bind(fd));`
`268`	`269`	`}`
`269`	`270`
`270`	`271`	`async function ftruncate(handle, len = 0) {`