buffer: don't set kNoZeroFill flag in allocUnsafe

vkurchatkin · jasnell · commit e966d1f5db5e · 2016-04-01T17:29:48.000-07:00
If `kNoZeroFill` is set here, it won't be reset in case of pooled allocation. In case of "slow" allocation it will be set later anyway. Fixes: #6006 PR-URL: #6007 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -148,8 +148,6 @@ Buffer.alloc = function(size, fill, encoding) {
 Buffer.allocUnsafe = function(size) {
   if (typeof size !== 'number')
     throw new TypeError('"size" argument must be a number');
-  if (size > 0)
-    flags[kNoZeroFill] = 1;
   return allocate(size);
 };
 
diff --git a/test/parallel/test-buffer-safe-unsafe.js b/test/parallel/test-buffer-safe-unsafe.js
@@ -7,8 +7,18 @@ const safe = Buffer.alloc(10);
 
 function isZeroFilled(buf) {
   for (let n = 0; n < buf.length; n++)
-    if (buf[n] > 0) return false;
+    if (buf[n] !== 0) return false;
   return true;
 }
 
 assert(isZeroFilled(safe));
+
+// Test that unsafe allocations doesn't affect subsequent safe allocations
+Buffer.allocUnsafe(10);
+assert(isZeroFilled(new Float64Array(10)));
+
+new Buffer(10);
+assert(isZeroFilled(new Float64Array(10)));
+
+Buffer.allocUnsafe(10);
+assert(isZeroFilled(Buffer.alloc(10)));
