policy: check for null instead of falsy in loop

Trott · BethGriggs · commit d83d55e6e5ff · 2022-01-24T17:35:59.000Z
This prepares the code for the no-cond-assign ESLint rule. PR-URL: #41614 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/lib/internal/policy/sri.js b/lib/internal/policy/sri.js
@@ -38,7 +38,7 @@ const parse = (str) => {
   let prevIndex = 0;
   let match;
   const entries = [];
-  while (match = RegExpPrototypeExec(kSRIPattern, str)) {
+  while ((match = RegExpPrototypeExec(kSRIPattern, str)) !== null) {
     if (match.index !== prevIndex) {
       throw new ERR_SRI_PARSE(str, str[prevIndex], prevIndex);
     }

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ const parse = (str) => {`
`38`	`38`	`let prevIndex = 0;`
`39`	`39`	`let match;`
`40`	`40`	`const entries = [];`
`41`		`- while (match = RegExpPrototypeExec(kSRIPattern, str)) {`
	`41`	`+ while ((match = RegExpPrototypeExec(kSRIPattern, str)) !== null) {`
`42`	`42`	`if (match.index !== prevIndex) {`
`43`	`43`	`throw new ERR_SRI_PARSE(str, str[prevIndex], prevIndex);`
`44`	`44`	`}`