readline: fix permanent deoptimizations

mscdex · evanlucas · commit d411dd0dad10 · 2017-05-02T12:46:22.000-05:00
PR-URL: #12456 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/readline.js b/lib/readline.js
@@ -449,8 +449,8 @@ Interface.prototype._tabComplete = function(lastKeypressWasTab) {
       }
 
       // If there is a common prefix to all matches, then apply that portion.
-      const f = completions.filter(function(e) { if (e) return e; });
-      const prefix = commonPrefix(f);
+      var f = completions.filter(function(e) { if (e) return e; });
+      var prefix = commonPrefix(f);
       if (prefix.length > completeOn.length) {
         self._insertString(prefix.slice(completeOn.length));
       }

Original file line number	Diff line number	Diff line change
`@@ -449,8 +449,8 @@ Interface.prototype._tabComplete = function(lastKeypressWasTab) {`
`449`	`449`	`}`
`450`	`450`
`451`	`451`	`// If there is a common prefix to all matches, then apply that portion.`
`452`		`- const f = completions.filter(function(e) { if (e) return e; });`
`453`		`- const prefix = commonPrefix(f);`
	`452`	`+ var f = completions.filter(function(e) { if (e) return e; });`
	`453`	`+ var prefix = commonPrefix(f);`
`454`	`454`	`if (prefix.length > completeOn.length) {`
`455`	`455`	`self._insertString(prefix.slice(completeOn.length));`
`456`	`456`	`}`