zlib: coerce -0 to +0 for crc32 seeds

panva · aduh95 · commit be4b3fe96627 · 2026-06-25T16:07:33.000+02:00
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #63556 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -969,6 +969,8 @@ function crc32(data, value = 0) {
     throw new ERR_INVALID_ARG_TYPE('data', ['Buffer', 'TypedArray', 'DataView', 'string'], data);
   }
   validateUint32(value, 'value');
+  // Coerce -0 to +0.
+  value += 0;
   return crc32Native(data, value);
 }
 
diff --git a/test/parallel/test-zlib-negative-zero.js b/test/parallel/test-zlib-negative-zero.js
@@ -0,0 +1,8 @@
+'use strict';
+
+require('../common');
+
+const assert = require('assert');
+const zlib = require('zlib');
+
+assert.strictEqual(zlib.crc32('', -0), zlib.crc32('', 0));

Original file line number	Diff line number	Diff line change
`@@ -969,6 +969,8 @@ function crc32(data, value = 0) {`
`969`	`969`	`throw new ERR_INVALID_ARG_TYPE('data', ['Buffer', 'TypedArray', 'DataView', 'string'], data);`
`970`	`970`	`}`
`971`	`971`	`validateUint32(value, 'value');`
	`972`	`+ // Coerce -0 to +0.`
	`973`	`+ value += 0;`
`972`	`974`	`return crc32Native(data, value);`
`973`	`975`	`}`
`974`	`976`