child_process: remove unreachable execSync() code

cjihrig · MylesBorins · commit b867294aa074 · 2016-11-18T19:03:55.000-05:00
Code coverage showed that the execSync() variable inheritStderr was never set to the default value of true. This is because the default case is hit whenever normalizeExecArgs() returns an object without an 'options' property. However, this can never be the case because normalizeExecArgs() unconditionally creates the options object. This commit removes the unreachable code. PR-URL: #9209 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
diff --git a/lib/child_process.js b/lib/child_process.js
@@ -512,7 +512,7 @@ exports.execFileSync = execFileSync;
 
 function execSync(command /*, options*/) {
   var opts = normalizeExecArgs.apply(null, arguments);
-  var inheritStderr = opts.options ? !opts.options.stdio : true;
+  var inheritStderr = !opts.options.stdio;
 
   var ret = spawnSync(opts.file, opts.options);
   ret.cmd = command;
