src: remove duplicate HMAC_Init calls

bnoordhuis · Fishrock123 · commit b7e661b12c8f · 2016-07-05T22:36:45.000+02:00
PR-URL: #7374 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -3591,13 +3591,10 @@ void Hmac::HmacInit(const char* hash_type, const char* key, int key_len) {
     return env()->ThrowError("Unknown message digest");
   }
   HMAC_CTX_init(&ctx_);
-  int result = 0;
   if (key_len == 0) {
-    result = HMAC_Init(&ctx_, "", 0, md);
-  } else {
-    result = HMAC_Init(&ctx_, key, key_len, md);
+    key = "";
   }
-  if (!result) {
+  if (!HMAC_Init(&ctx_, key, key_len, md)) {
     return ThrowCryptoError(env(), ERR_get_error());
   }
   initialised_ = true;

Original file line number	Diff line number	Diff line change
`@@ -3591,13 +3591,10 @@ void Hmac::HmacInit(const char* hash_type, const char* key, int key_len) {`
`3591`	`3591`	`return env()->ThrowError("Unknown message digest");`
`3592`	`3592`	`}`
`3593`	`3593`	`HMAC_CTX_init(&ctx_);`
`3594`		`- int result = 0;`
`3595`	`3594`	`if (key_len == 0) {`
`3596`		`- result = HMAC_Init(&ctx_, "", 0, md);`
`3597`		`- } else {`
`3598`		`- result = HMAC_Init(&ctx_, key, key_len, md);`
	`3595`	`+ key = "";`
`3599`	`3596`	`}`
`3600`		`- if (!result) {`
	`3597`	`+ if (!HMAC_Init(&ctx_, key, key_len, md)) {`
`3601`	`3598`	`return ThrowCryptoError(env(), ERR_get_error());`
`3602`	`3599`	`}`
`3603`	`3600`	`initialised_ = true;`