src: implement NodePlatform::PostJob

backes · targos · commit b65e5aeaa7bd · 2020-10-18T20:17:48.000+02:00
V8 is starting to use the job API for Wasm compilation, so the node platform should implement that. PR-URL: #35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
diff --git a/src/node_platform.cc b/src/node_platform.cc
@@ -513,6 +513,12 @@ bool NodePlatform::FlushForegroundTasks(Isolate* isolate) {
   return per_isolate->FlushForegroundTasksInternal();
 }
 
+std::unique_ptr<v8::JobHandle> NodePlatform::PostJob(v8::TaskPriority priority,
+                                       std::unique_ptr<v8::JobTask> job_task) {
+  return v8::platform::NewDefaultJobHandle(
+      this, priority, std::move(job_task), NumberOfWorkerThreads());
+}
+
 bool NodePlatform::IdleTasksEnabled(Isolate* isolate) {
   return ForIsolate(isolate)->IdleTasksEnabled();
 }
diff --git a/src/node_platform.h b/src/node_platform.h
@@ -154,6 +154,9 @@ class NodePlatform : public MultiIsolatePlatform {
   double CurrentClockTimeMillis() override;
   v8::TracingController* GetTracingController() override;
   bool FlushForegroundTasks(v8::Isolate* isolate) override;
+  std::unique_ptr<v8::JobHandle> PostJob(
+      v8::TaskPriority priority,
+      std::unique_ptr<v8::JobTask> job_task) override;
 
   void RegisterIsolate(v8::Isolate* isolate, uv_loop_t* loop) override;
   void RegisterIsolate(v8::Isolate* isolate,

Original file line number	Diff line number	Diff line change
`@@ -513,6 +513,12 @@ bool NodePlatform::FlushForegroundTasks(Isolate* isolate) {`
`513`	`513`	`return per_isolate->FlushForegroundTasksInternal();`
`514`	`514`	`}`
`515`	`515`
	`516`	`+std::unique_ptr<v8::JobHandle> NodePlatform::PostJob(v8::TaskPriority priority,`
	`517`	`+ std::unique_ptr<v8::JobTask> job_task) {`
	`518`	`+ return v8::platform::NewDefaultJobHandle(`
	`519`	`+ this, priority, std::move(job_task), NumberOfWorkerThreads());`
	`520`	`+}`
	`521`	`+`
`516`	`522`	`bool NodePlatform::IdleTasksEnabled(Isolate* isolate) {`
`517`	`523`	`return ForIsolate(isolate)->IdleTasksEnabled();`
`518`	`524`	`}`