events: set target property to null

benjamingr · Benjamin Gruenbaum · commit b2b95eb7543d · 2020-05-31T13:29:42.000+03:00
PR-URL: #33615 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -64,6 +64,7 @@ class Event {
       enumerable: true,
       configurable: false
     });
+    this[kTarget] = null;
   }
 
   [customInspectSymbol](depth, options) {
@@ -245,7 +246,7 @@ class EventTarget {
     }
 
     if (this.#emitting.has(event.type) ||
-        event[kTarget] !== undefined) {
+        event[kTarget] !== null) {
       throw new ERR_EVENT_RECURSION(event.type);
     }
 
diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -385,6 +385,7 @@ const ev = new Event('foo');
 {
   const target = new EventTarget();
   const event = new Event('foo');
+  strictEqual(event.target, null);
   target.addEventListener('foo', common.mustCall((event) => {
     strictEqual(event.target, target);
     strictEqual(event.currentTarget, target);

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,7 @@ class Event {`
`64`	`64`	`enumerable: true,`
`65`	`65`	`configurable: false`
`66`	`66`	`});`
	`67`	`+ this[kTarget] = null;`
`67`	`68`	`}`
`68`	`69`
`69`	`70`	`[customInspectSymbol](depth, options) {`
`@@ -245,7 +246,7 @@ class EventTarget {`
`245`	`246`	`}`
`246`	`247`
`247`	`248`	`if (this.#emitting.has(event.type) \|\|`
`248`		`- event[kTarget] !== undefined) {`
	`249`	`+ event[kTarget] !== null) {`
`249`	`250`	`throw new ERR_EVENT_RECURSION(event.type);`
`250`	`251`	`}`
`251`	`252`
Original file line number	Diff line number	Diff line change
`@@ -385,6 +385,7 @@ const ev = new Event('foo');`
`385`	`385`	`{`
`386`	`386`	`const target = new EventTarget();`
`387`	`387`	`const event = new Event('foo');`
	`388`	`+ strictEqual(event.target, null);`
`388`	`389`	`target.addEventListener('foo', common.mustCall((event) => {`
`389`	`390`	`strictEqual(event.target, target);`
`390`	`391`	`strictEqual(event.currentTarget, target);`