src: update NODE_MODULE_VERSION to 88

targos · targos · commit b1e8e0e60467 · 2020-10-18T20:16:56.000+02:00
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.6. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
diff --git a/doc/abi_version_registry.json b/doc/abi_version_registry.json
@@ -1,5 +1,6 @@
 {
   "NODE_MODULE_VERSION": [
+    { "modules": 88, "runtime": "node",     "variant": "v8_8.6",               "versions": "15.0.0-pre" },
     { "modules": 87, "runtime": "electron", "variant": "electron",             "versions": "12" },
     { "modules": 86, "runtime": "node",     "variant": "v8_8.4",               "versions": "15.0.0-pre" },
     { "modules": 85, "runtime": "electron", "variant": "electron",             "versions": "11" },
diff --git a/src/node_version.h b/src/node_version.h
@@ -89,7 +89,7 @@
  * version matching should open a pull request to reserve a number in this
  * registry.
  */
-#define NODE_MODULE_VERSION 86
+#define NODE_MODULE_VERSION 88
 
 // The NAPI_VERSION provided by this version of the runtime. This is the version
 // which the Node binary being built supports.

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"NODE_MODULE_VERSION": [`
	`3`	`+ { "modules": 88, "runtime": "node", "variant": "v8_8.6", "versions": "15.0.0-pre" },`
`3`	`4`	`{ "modules": 87, "runtime": "electron", "variant": "electron", "versions": "12" },`
`4`	`5`	`{ "modules": 86, "runtime": "node", "variant": "v8_8.4", "versions": "15.0.0-pre" },`
`5`	`6`	`{ "modules": 85, "runtime": "electron", "variant": "electron", "versions": "11" },`