src: remove use of SSL_OP_SINGLE_DH_USE

tniessen · danielleadams · commit a4a433fc0b24 · 2023-04-10T20:55:12.000-04:00
This option does not have any effect in any supported OpenSSL version. Refs: #46954 PR-URL: #46955 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/src/crypto/crypto_context.cc b/src/crypto/crypto_context.cc
@@ -878,8 +878,6 @@ void SecureContext::SetDHParam(const FunctionCallbackInfo<Value>& args) {
         env->isolate(), "DH parameter is less than 2048 bits"));
   }
 
-  SSL_CTX_set_options(sc->ctx_.get(), SSL_OP_SINGLE_DH_USE);
-
   if (!SSL_CTX_set_tmp_dh(sc->ctx_.get(), dh.get())) {
     return THROW_ERR_CRYPTO_OPERATION_FAILED(
         env, "Error setting temp DH parameter");

Original file line number	Diff line number	Diff line change
`@@ -878,8 +878,6 @@ void SecureContext::SetDHParam(const FunctionCallbackInfo<Value>& args) {`
`878`	`878`	`env->isolate(), "DH parameter is less than 2048 bits"));`
`879`	`879`	`}`
`880`	`880`
`881`		`- SSL_CTX_set_options(sc->ctx_.get(), SSL_OP_SINGLE_DH_USE);`
`882`		`-`
`883`	`881`	`if (!SSL_CTX_set_tmp_dh(sc->ctx_.get(), dh.get())) {`
`884`	`882`	`return THROW_ERR_CRYPTO_OPERATION_FAILED(`
`885`	`883`	`env, "Error setting temp DH parameter");`