fs: add missing call to uv_fs_req_cleanup

Justin-Nietzel · RafaelGSS · commit 9e13bf0a81e1 · 2025-05-12T12:38:47.000-03:00
Always call uv_fs_req_cleanup after calling uv_fs_open instead of just when uv_fs_open returns a negative result. I referenced ReadFileSync from node:js2c when making this change. https://github.com/bnoordhuis made the same suggestion based on the PR #49691. Fixes: #57800 PR-URL: #57811 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> CVE-ID: CVE-2025-23165
diff --git a/src/node_file.cc b/src/node_file.cc
@@ -2615,9 +2615,9 @@ static void ReadFileUtf8(const FunctionCallbackInfo<Value>& args) {
     FS_SYNC_TRACE_END(open);
     if (req.result < 0) {
       uv_fs_req_cleanup(&req);
-      // req will be cleaned up by scope leave.
       return env->ThrowUVException(req.result, "open", nullptr, path.out());
     }
+    uv_fs_req_cleanup(&req);
   }
 
   auto defer_close = OnScopeLeave([file, is_fd, &req]() {

Original file line number	Diff line number	Diff line change
`@@ -2615,9 +2615,9 @@ static void ReadFileUtf8(const FunctionCallbackInfo<Value>& args) {`
`2615`	`2615`	`FS_SYNC_TRACE_END(open);`
`2616`	`2616`	`if (req.result < 0) {`
`2617`	`2617`	`uv_fs_req_cleanup(&req);`
`2618`		`- // req will be cleaned up by scope leave.`
`2619`	`2618`	`return env->ThrowUVException(req.result, "open", nullptr, path.out());`
`2620`	`2619`	`}`
	`2620`	`+ uv_fs_req_cleanup(&req);`
`2621`	`2621`	`}`
`2622`	`2622`
`2623`	`2623`	`auto defer_close = OnScopeLeave([file, is_fd, &req]() {`