build: option to use custom inspector_protocol path

codebytere · web-flow · commit 98da424ac46e · 2025-06-28T09:23:18.000Z
PR-URL: #58839 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/node.gni b/node.gni
@@ -16,6 +16,9 @@ declare_args() {
   # The location of simdutf - use the one from node's deps by default.
   node_simdutf_path = "//third_party/simdutf"
 
+  # The location of inspector_protocol - use the one from node's deps by default.
+  node_inspector_protocol_path = "//third_party/inspector_protocol"
+
   # The NODE_MODULE_VERSION defined in node_version.h.
   node_module_version = exec_script("$node_path/tools/getmoduleversion.py", [], "value")
 
diff --git a/src/inspector/unofficial.gni b/src/inspector/unofficial.gni
@@ -13,7 +13,7 @@ template("inspector_gn_build") {
   }
 
   node_gen_dir = get_label_info("../..", "target_gen_dir")
-  protocol_tool_path = "../../deps/inspector_protocol"
+  protocol_tool_path = "$node_inspector_protocol_path"
 
   gypi_values = exec_script(
       "../../tools/gypi_to_gn.py",
diff --git a/unofficial.gni b/unofficial.gni
@@ -195,13 +195,14 @@ template("node_gn_build") {
     }
     if (node_enable_inspector) {
       deps += [
-        "src/inspector:crdtp",
+        "$node_inspector_protocol_path:crdtp",
         "src/inspector:node_protocol_generated_sources",
         "src/inspector:v8_inspector_compress_protocol_json",
       ]
       include_dirs = [
         "$target_gen_dir/src",
         "$target_gen_dir/src/inspector",
+        "$node_inspector_protocol_path",
       ]
       node_inspector = exec_script(
           "./tools/gypi_to_gn.py",

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ template("inspector_gn_build") {`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`node_gen_dir = get_label_info("../..", "target_gen_dir")`
`16`		`- protocol_tool_path = "../../deps/inspector_protocol"`
	`16`	`+ protocol_tool_path = "$node_inspector_protocol_path"`
`17`	`17`
`18`	`18`	`gypi_values = exec_script(`
`19`	`19`	`"../../tools/gypi_to_gn.py",`
Original file line number	Diff line number	Diff line change
`@@ -195,13 +195,14 @@ template("node_gn_build") {`
`195`	`195`	`}`
`196`	`196`	`if (node_enable_inspector) {`
`197`	`197`	`deps += [`
`198`		`- "src/inspector:crdtp",`
	`198`	`+ "$node_inspector_protocol_path:crdtp",`
`199`	`199`	`"src/inspector:node_protocol_generated_sources",`
`200`	`200`	`"src/inspector:v8_inspector_compress_protocol_json",`
`201`	`201`	`]`
`202`	`202`	`include_dirs = [`
`203`	`203`	`"$target_gen_dir/src",`
`204`	`204`	`"$target_gen_dir/src/inspector",`
	`205`	`+ "$node_inspector_protocol_path",`
`205`	`206`	`]`
`206`	`207`	`node_inspector = exec_script(`
`207`	`208`	`"./tools/gypi_to_gn.py",`