src: remove shadowed variable in OptionsParser

codebytere · web-flow · commit 97d0f777ac3c · 2023-03-01T10:35:03.000Z
PR-URL: #46672 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
diff --git a/src/node_options-inl.h b/src/node_options-inl.h
@@ -387,12 +387,12 @@ void OptionsParser<Options>::Parse(
         implied_name.insert(2, "no-");
       }
       auto implications = implications_.equal_range(implied_name);
-      for (auto it = implications.first; it != implications.second; ++it) {
-        if (it->second.type == kV8Option) {
-          v8_args->push_back(it->second.name);
+      for (auto imp = implications.first; imp != implications.second; ++imp) {
+        if (imp->second.type == kV8Option) {
+          v8_args->push_back(imp->second.name);
         } else {
-          *it->second.target_field->template Lookup<bool>(options) =
-              it->second.target_value;
+          *imp->second.target_field->template Lookup<bool>(options) =
+              imp->second.target_value;
         }
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -387,12 +387,12 @@ void OptionsParser<Options>::Parse(`
`387`	`387`	`implied_name.insert(2, "no-");`
`388`	`388`	`}`
`389`	`389`	`auto implications = implications_.equal_range(implied_name);`
`390`		`- for (auto it = implications.first; it != implications.second; ++it) {`
`391`		`- if (it->second.type == kV8Option) {`
`392`		`- v8_args->push_back(it->second.name);`
	`390`	`+ for (auto imp = implications.first; imp != implications.second; ++imp) {`
	`391`	`+ if (imp->second.type == kV8Option) {`
	`392`	`+ v8_args->push_back(imp->second.name);`
`393`	`393`	`} else {`
`394`		`- *it->second.target_field->template Lookup<bool>(options) =`
`395`		`- it->second.target_value;`
	`394`	`+ *imp->second.target_field->template Lookup<bool>(options) =`
	`395`	`+ imp->second.target_value;`
`396`	`396`	`}`
`397`	`397`	`}`
`398`	`398`	`}`