Skip to content

Commit 9077f63

Browse files
TrottMyles Borins
Trott
authored and
Myles Borins
committed
tools: replace custom lint rule for getter/setter
Replace custom `no-definegetter-definesetter` lint rule with ESLint's built-in `no-restricted-properties`. Refs: #9112 (review) PR-URL: #9194 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
1 parent 5c42d98 commit 9077f63

File tree

2 files changed

+6
-33
lines changed

2 files changed

+6
-33
lines changed

‎.eslintrc‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,12 @@ rules:
6363
object: assert,
6464
property: deepEqual,
6565
message: Please use assert.deepStrictEqual().
66+
}, {
67+
property: __defineGetter__,
68+
message: __defineGetter__ is deprecated.
69+
}, {
70+
property: __defineSetter__,
71+
message: __defineSetter__ is deprecated.
6672
}]
6773

6874
# Stylistic Issues
@@ -112,7 +118,6 @@ rules:
112118
align-multiline-assignment: 2
113119
assert-fail-single-argument: 2
114120
new-with-error: [2, Error, RangeError, TypeError, SyntaxError, ReferenceError]
115-
no-definegetter-definesetter: 2
116121

117122
# Global scoped method and vars
118123
globals:

‎tools/eslint-rules/no-definegetter-definesetter.js‎

Lines changed: 0 additions & 32 deletions
This file was deleted.

0 commit comments

Comments
 (0)