build: add -flax-vector-conversions to V8 build

targos · richardlau · commit 8b97e2e0a7e3 · 2024-03-25T18:15:10.000Z
The flag is on by default in Clang and V8 recently made a change that makes it necessary with GCC. Refs: v8/v8@7fbbf93 Refs: https://github.com/llvm/llvm-project/blob/54067c5fbe9fc13ab195cdddb8f17e18d72b5fe4/clang/include/clang/Basic/LangOptions.def#L133-L134 Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html#index-flax-vector-conversions PR-URL: #51257 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
diff --git a/tools/v8_gypfiles/toolchain.gypi b/tools/v8_gypfiles/toolchain.gypi
@@ -138,7 +138,11 @@
         'cflags': [ '-Werror', '-Wno-unknown-pragmas' ],
       },{
         'cflags!': [ '-Wall', '-Wextra' ],
-        'cflags': [ '-Wno-return-type' ],
+        'cflags': [
+          '-Wno-return-type',
+          # On by default in Clang and V8 requires it at least for arm64.
+          '-flax-vector-conversions',
+        ],
       }],
       ['v8_target_arch=="arm"', {
         'defines': [
