lib: use full URL to GitHub issues in comments

Trott · Trott · commit 8a8416f84169 · 2020-08-10T16:33:49.000-07:00
Don't assume the reader of the code will know where to find the issue tracker. Provide the full URL. This is especially important if the issue tracker should move again. PR-URL: #34686 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -201,7 +201,8 @@ function initEventTarget(self) {
 
 class EventTarget {
   // Used in checking whether an object is an EventTarget. This is a well-known
-  // symbol as EventTarget may be used cross-realm. See discussion in #33661.
+  // symbol as EventTarget may be used cross-realm.
+  // Ref: https://github.com/nodejs/node/pull/33661
   static [kIsEventTarget] = true;
 
   constructor() {
@@ -520,8 +521,8 @@ function validateEventListenerOptions(options) {
 // Test whether the argument is an event object. This is far from a fool-proof
 // test, for example this input will result in a false positive:
 // > isEventTarget({ constructor: EventTarget })
-// It stands in its current implementation as a compromise. For the relevant
-// discussion, see #33661.
+// It stands in its current implementation as a compromise.
+// Ref: https://github.com/nodejs/node/pull/33661
 function isEventTarget(obj) {
   return obj && obj.constructor && obj.constructor[kIsEventTarget];
 }
diff --git a/lib/internal/stream_base_commons.js b/lib/internal/stream_base_commons.js
@@ -208,7 +208,8 @@ function onStreamRead(arrayBuffer) {
   }
 
   if (nread !== UV_EOF) {
-    // #34375 CallJSOnreadMethod expects the return value to be a buffer.
+    // CallJSOnreadMethod expects the return value to be a buffer.
+    // Ref: https://github.com/nodejs/node/pull/34375
     stream.destroy(errnoException(nread, 'read'));
     return;
   }
@@ -228,7 +229,8 @@ function onStreamRead(arrayBuffer) {
     if (handle.readStop) {
       const err = handle.readStop();
       if (err) {
-        // #34375 CallJSOnreadMethod expects the return value to be a buffer.
+        // CallJSOnreadMethod expects the return value to be a buffer.
+        // Ref: https://github.com/nodejs/node/pull/34375
         stream.destroy(errnoException(err, 'read'));
         return;
       }

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,8 @@ function onStreamRead(arrayBuffer) {`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`if (nread !== UV_EOF) {`
`211`		`- // #34375 CallJSOnreadMethod expects the return value to be a buffer.`
	`211`	`+ // CallJSOnreadMethod expects the return value to be a buffer.`
	`212`	`+ // Ref: https://github.com/nodejs/node/pull/34375`
`212`	`213`	`stream.destroy(errnoException(nread, 'read'));`
`213`	`214`	`return;`
`214`	`215`	`}`
`@@ -228,7 +229,8 @@ function onStreamRead(arrayBuffer) {`
`228`	`229`	`if (handle.readStop) {`
`229`	`230`	`const err = handle.readStop();`
`230`	`231`	`if (err) {`
`231`		`- // #34375 CallJSOnreadMethod expects the return value to be a buffer.`
	`232`	`+ // CallJSOnreadMethod expects the return value to be a buffer.`
	`233`	`+ // Ref: https://github.com/nodejs/node/pull/34375`
`232`	`234`	`stream.destroy(errnoException(err, 'read'));`
`233`	`235`	`return;`
`234`	`236`	`}`