url: align url format behavior with browsers

Lxxyx · ruyadorno · commit 889654d36cfb · 2021-01-21T17:48:11.000-05:00
Fixes: #36887 PR-URL: #36903 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -437,7 +437,7 @@ ObjectDefineProperties(URL.prototype, {
           ret += '@';
         }
         ret += options.unicode ?
-          domainToUnicode(this.hostname) : this.hostname;
+          domainToUnicode(ctx.host) : ctx.host;
         if (ctx.port !== null)
           ret += `:${ctx.port}`;
       }
diff --git a/test/parallel/test-whatwg-url-override-hostname.js b/test/parallel/test-whatwg-url-override-hostname.js
@@ -0,0 +1,20 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+
+{
+  const url = new (class extends URL { get hostname() { return 'bar.com'; } })('http://foo.com/');
+  assert.strictEqual(url.href, 'http://foo.com/');
+  assert.strictEqual(url.toString(), 'http://foo.com/');
+  assert.strictEqual(url.toJSON(), 'http://foo.com/');
+  assert.strictEqual(url.hash, '');
+  assert.strictEqual(url.host, 'foo.com');
+  assert.strictEqual(url.hostname, 'bar.com');
+  assert.strictEqual(url.origin, 'http://foo.com');
+  assert.strictEqual(url.password, '');
+  assert.strictEqual(url.protocol, 'http:');
+  assert.strictEqual(url.username, '');
+  assert.strictEqual(url.search, '');
+  assert.strictEqual(url.searchParams.toString(), '');
+}

Original file line number	Diff line number	Diff line change
`@@ -437,7 +437,7 @@ ObjectDefineProperties(URL.prototype, {`
`437`	`437`	`ret += '@';`
`438`	`438`	`}`
`439`	`439`	`ret += options.unicode ?`
`440`		`- domainToUnicode(this.hostname) : this.hostname;`
	`440`	`+ domainToUnicode(ctx.host) : ctx.host;`
`441`	`441`	`if (ctx.port !== null)`
`442`	`442`	ret += `:${ctx.port}`;
`443`	`443`	`}`