buffer: don't predefine error

ah-yu · MylesBorins · commit 883281bca99b · 2017-12-11T17:24:23.000-05:00
PR-URL: #17021 Fixes: #16994 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -449,14 +449,12 @@ Buffer.isEncoding = function isEncoding(encoding) {
 };
 Buffer[kIsEncodingSymbol] = Buffer.isEncoding;
 
-const kConcatErr = new errors.TypeError(
-  'ERR_INVALID_ARG_TYPE', 'list', ['Array', 'Buffer', 'Uint8Array']
-);
-
 Buffer.concat = function concat(list, length) {
   var i;
   if (!Array.isArray(list))
-    throw kConcatErr;
+    throw new errors.TypeError(
+      'ERR_INVALID_ARG_TYPE', 'list', ['Array', 'Buffer', 'Uint8Array']
+    );
 
   if (list.length === 0)
     return new FastBuffer();
@@ -474,7 +472,9 @@ Buffer.concat = function concat(list, length) {
   for (i = 0; i < list.length; i++) {
     var buf = list[i];
     if (!isUint8Array(buf))
-      throw kConcatErr;
+      throw new errors.TypeError(
+        'ERR_INVALID_ARG_TYPE', 'list', ['Array', 'Buffer', 'Uint8Array']
+      );
     _copy(buf, buffer, pos);
     pos += buf.length;
   }
