src: add "missing" bash completion options

danbev · danbev · commit 813368c03719 · 2020-06-08T13:56:17.000+02:00
Currently, when using the bash completions for node the normal completions for filenames directories do not work. For example, after finding a node completion and then wanting to use tab completion for a filename in the test directory, it is only possible to get the name of the test directory completed, followed by a space. What is expected is to be able to continue with tab completion for directories. This commit adds options to the complete command to enable default bash completions. PR-URL: #33744 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
diff --git a/src/node_options.cc b/src/node_options.cc
@@ -831,7 +831,8 @@ std::string GetBashCompletion() {
          "    return 0\n"
          "  fi\n"
          "}\n"
-         "complete -F _node_complete node node_g";
+         "complete -o filenames -o nospace -o bashdefault "
+         "-F _node_complete node node_g";
   return out.str();
 }
 
diff --git a/test/parallel/test-bash-completion.js b/test/parallel/test-bash-completion.js
@@ -24,7 +24,8 @@ const suffix = `' -- "\${cur_word}") )
     return 0
   fi
 }
-complete -F _node_complete node node_g`.replace(/\r/g, '');
+complete -o filenames -o nospace -o bashdefault -F _node_complete node node_g`
+  .replace(/\r/g, '');
 
 assert.ok(
   output.includes(prefix),

Original file line number	Diff line number	Diff line change
`@@ -831,7 +831,8 @@ std::string GetBashCompletion() {`
`831`	`831`	`" return 0\n"`
`832`	`832`	`" fi\n"`
`833`	`833`	`"}\n"`
`834`		`- "complete -F _node_complete node node_g";`
	`834`	`+ "complete -o filenames -o nospace -o bashdefault "`
	`835`	`+ "-F _node_complete node node_g";`
`835`	`836`	`return out.str();`
`836`	`837`	`}`
`837`	`838`
Original file line number	Diff line number	Diff line change
@@ -24,7 +24,8 @@ const suffix = `' -- "\${cur_word}") )
`24`	`24`	`return 0`
`25`	`25`	`fi`
`26`	`26`	`}`
`27`		-complete -F _node_complete node node_g`.replace(/\r/g, '');
	`27`	+complete -o filenames -o nospace -o bashdefault -F _node_complete node node_g`
	`28`	`+ .replace(/\r/g, '');`
`28`	`29`
`29`	`30`	`assert.ok(`
`30`	`31`	`output.includes(prefix),`