src: use hex not decimal in IsArrayIndex

codebytere · codebytere · commit 7c2d33f38f45 · 2020-02-17T12:49:22.000-08:00
PR-URL: #31758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/module_wrap.cc b/src/module_wrap.cc
@@ -955,7 +955,7 @@ bool IsArrayIndex(Environment* env, Local<Value> p) {
   if (!n->ToInteger(context).ToLocal(&cmp_integer)) {
     return false;
   }
-  return n_dbl > 0 && n_dbl < (2 ^ 32) - 1;
+  return n_dbl > 0 && n_dbl < (1LL << 32) - 1;
 }
 
 Maybe<URL> ResolveExportsTarget(Environment* env,

Original file line number	Diff line number	Diff line change
`@@ -955,7 +955,7 @@ bool IsArrayIndex(Environment* env, Local<Value> p) {`
`955`	`955`	`if (!n->ToInteger(context).ToLocal(&cmp_integer)) {`
`956`	`956`	`return false;`
`957`	`957`	`}`
`958`		`- return n_dbl > 0 && n_dbl < (2 ^ 32) - 1;`
	`958`	`+ return n_dbl > 0 && n_dbl < (1LL << 32) - 1;`
`959`	`959`	`}`
`960`	`960`
`961`	`961`	`Maybe<URL> ResolveExportsTarget(Environment* env,`