trace_events: stop tracing agent in process.exit()

AndreasMadsen · MylesBorins · commit 7bf6be0b7c81 · 2018-01-10T01:42:26.000-05:00
PR-URL: #18005 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
diff --git a/src/node.cc b/src/node.cc
@@ -2358,6 +2358,9 @@ static void WaitForInspectorDisconnect(Environment* env) {
 
 static void Exit(const FunctionCallbackInfo<Value>& args) {
   WaitForInspectorDisconnect(Environment::GetCurrent(args));
+  if (trace_enabled) {
+    v8_platform.StopTracingAgent();
+  }
   exit(args[0]->Int32Value());
 }
 
diff --git a/test/parallel/test-trace-events-process-exit.js b/test/parallel/test-trace-events-process-exit.js
@@ -0,0 +1,22 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const cp = require('child_process');
+const fs = require('fs');
+
+const FILE_NAME = 'node_trace.1.log';
+
+common.refreshTmpDir();
+process.chdir(common.tmpDir);
+
+const proc = cp.spawn(process.execPath,
+                      [ '--trace-events-enabled',
+                        '-e', 'process.exit()' ]);
+
+proc.once('exit', common.mustCall(() => {
+  assert(common.fileExists(FILE_NAME));
+  fs.readFile(FILE_NAME, common.mustCall((err, data) => {
+    const traces = JSON.parse(data.toString()).traceEvents;
+    assert(traces.length > 0);
+  }));
+}));

Original file line number	Diff line number	Diff line change
`@@ -2358,6 +2358,9 @@ static void WaitForInspectorDisconnect(Environment* env) {`
`2358`	`2358`
`2359`	`2359`	`static void Exit(const FunctionCallbackInfo<Value>& args) {`
`2360`	`2360`	`WaitForInspectorDisconnect(Environment::GetCurrent(args));`
	`2361`	`+ if (trace_enabled) {`
	`2362`	`+ v8_platform.StopTracingAgent();`
	`2363`	`+ }`
`2361`	`2364`	`exit(args[0]->Int32Value());`
`2362`	`2365`	`}`
`2363`	`2366`