zlib: refactor to use primordial instead of <string>.startsWith

rchougule · targos · commit 740638de0ff6 · 2021-06-11T09:29:55.000+02:00
PR-URL: #36718 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -37,6 +37,7 @@ const {
   ObjectKeys,
   ObjectSetPrototypeOf,
   ReflectApply,
+  StringPrototypeStartsWith,
   Symbol,
   TypedArrayPrototypeFill,
   Uint32Array,
@@ -781,7 +782,9 @@ function createConvenienceMethod(ctor, sync) {
 
 const kMaxBrotliParam = MathMax(...ArrayPrototypeMap(
   ObjectKeys(constants),
-  (key) => (key.startsWith('BROTLI_PARAM_') ? constants[key] : 0)
+  (key) => (StringPrototypeStartsWith(key, 'BROTLI_PARAM_') ?
+    constants[key] :
+    0)
 ));
 
 const brotliInitParamsArray = new Uint32Array(kMaxBrotliParam + 1);
@@ -922,7 +925,7 @@ ObjectDefineProperties(module.exports, {
 // These should be considered deprecated
 // expose all the zlib constants
 for (const bkey of ObjectKeys(constants)) {
-  if (bkey.startsWith('BROTLI')) continue;
+  if (StringPrototypeStartsWith(bkey, 'BROTLI')) continue;
   ObjectDefineProperty(module.exports, bkey, {
     enumerable: false, value: constants[bkey], writable: false
   });
