lib: add process to internal module wrapper

addaleax · MylesBorins · commit 738b0a1f2ef8 · 2018-02-26T18:39:42.000-05:00
Share `process` through the module wrapper rather than relying on nobody messing with `global.process`. Backport-PR-URL: #19006 PR-URL: #17198 Fixes: #6802 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
diff --git a/lib/internal/bootstrap_node.js b/lib/internal/bootstrap_node.js
@@ -634,7 +634,7 @@
   };
 
   NativeModule.wrapper = [
-    '(function (exports, require, module, internalBinding) {',
+    '(function (exports, require, module, internalBinding, process) {',
     '\n});'
   ];
 
@@ -650,7 +650,7 @@
         lineOffset: 0,
         displayErrors: true
       });
-      fn(this.exports, NativeModule.require, this, internalBinding);
+      fn(this.exports, NativeModule.require, this, internalBinding, process);
 
       this.loaded = true;
     } finally {
diff --git a/test/parallel/test-repl-let-process.js b/test/parallel/test-repl-let-process.js
@@ -0,0 +1,10 @@
+'use strict';
+const common = require('../common');
+const repl = require('repl');
+
+common.globalCheck = false;
+
+// Regression test for https://github.com/nodejs/node/issues/6802
+const input = new common.ArrayStream();
+repl.start({ input, output: process.stdout, useGlobal: true });
+input.run(['let process']);
