fs: use rest param & Reflect.apply in makeCallback

mithunsasidharan · MylesBorins · commit 715baf821447 · 2017-12-12T03:28:26.000-05:00
PR-URL: #17486 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
diff --git a/lib/fs.js b/lib/fs.js
@@ -145,8 +145,8 @@ function makeCallback(cb) {
     throw new errors.TypeError('ERR_INVALID_CALLBACK');
   }
 
-  return function() {
-    return cb.apply(undefined, arguments);
+  return function(...args) {
+    return Reflect.apply(cb, undefined, args);
   };
 }
 

Original file line number	Diff line number	Diff line change
`@@ -145,8 +145,8 @@ function makeCallback(cb) {`
`145`	`145`	`throw new errors.TypeError('ERR_INVALID_CALLBACK');`
`146`	`146`	`}`
`147`	`147`
`148`		`- return function() {`
`149`		`- return cb.apply(undefined, arguments);`
	`148`	`+ return function(...args) {`
	`149`	`+ return Reflect.apply(cb, undefined, args);`
`150`	`150`	`};`
`151`	`151`	`}`
`152`	`152`