process: ignore asyncId 0 in exception handler

apapirovski · BethGriggs · commit 700f766bea10 · 2022-01-24T17:35:43.000Z
Today, the global uncaught exception handler is the only place where asyncId 0 is not ignored and we still proceed to call emitAfter. This would've already failed one of our correctness tests in async_hooks if not for some other code meant to handle a different edge case. Fixes: #22982 PR-URL: #41424 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/process/execution.js b/lib/internal/process/execution.js
@@ -20,7 +20,8 @@ const {
   clearAsyncIdStack,
   hasAsyncIdStack,
   afterHooksExist,
-  emitAfter
+  emitAfter,
+  popAsyncContext,
 } = require('internal/async_hooks');
 
 // shouldAbortOnUncaughtToggle is a typed array for faster
@@ -183,7 +184,11 @@ function createOnGlobalUncaughtException() {
     // Emit the after() hooks now that the exception has been handled.
     if (afterHooksExist()) {
       do {
-        emitAfter(executionAsyncId());
+        const asyncId = executionAsyncId();
+        if (asyncId === 0)
+          popAsyncContext(0);
+        else
+          emitAfter(asyncId);
       } while (hasAsyncIdStack());
     }
     // And completely empty the id stack, including anything that may be
diff --git a/test/async-hooks/init-hooks.js b/test/async-hooks/init-hooks.js
@@ -168,9 +168,6 @@ class ActivityCollector {
       }
       const err = new Error(`Found a handle whose ${hook}` +
                             ' hook was invoked but not its init hook');
-      // Don't throw if we see invocations due to an assertion in a test
-      // failing since we want to list the assertion failure instead
-      if (/process\._fatalException/.test(err.stack)) return null;
       throw err;
     }
     return h;
diff --git a/test/async-hooks/test-unhandled-exception-valid-ids.js b/test/async-hooks/test-unhandled-exception-valid-ids.js
@@ -0,0 +1,17 @@
+'use strict';
+
+const common = require('../common');
+const initHooks = require('./init-hooks');
+
+const hooks = initHooks();
+hooks.enable();
+
+setImmediate(() => {
+  throw new Error();
+});
+
+setTimeout(() => {
+  throw new Error();
+}, 1);
+
+process.on('uncaughtException', common.mustCall(2));

Original file line number	Diff line number	Diff line change
`@@ -168,9 +168,6 @@ class ActivityCollector {`
`168`	`168`	`}`
`169`	`169`	const err = new Error(`Found a handle whose ${hook}` +
`170`	`170`	`' hook was invoked but not its init hook');`
`171`		`- // Don't throw if we see invocations due to an assertion in a test`
`172`		`- // failing since we want to list the assertion failure instead`
`173`		`- if (/process\._fatalException/.test(err.stack)) return null;`
`174`	`171`	`throw err;`
`175`	`172`	`}`
`176`	`173`	`return h;`