util: fix invalid date output with util.inspect

rumkin · evanlucas · commit 6d1527bb37a2 · 2016-05-17T08:08:15.000-05:00
Prevent util.inspect of throwing on date object with invalid date value. It changed to output result of toString method call. PR-URL: #6504 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/lib/util.js b/lib/util.js
@@ -348,7 +348,11 @@ function formatValue(ctx, value, recurseTimes) {
       return ctx.stylize(RegExp.prototype.toString.call(value), 'regexp');
     }
     if (isDate(value)) {
-      return ctx.stylize(Date.prototype.toISOString.call(value), 'date');
+      if (Number.isNaN(value.getTime())) {
+        return ctx.stylize(value.toString(), 'date');
+      } else {
+        return ctx.stylize(Date.prototype.toISOString.call(value), 'date');
+      }
     }
     if (isError(value)) {
       return formatError(value);
diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js
@@ -12,8 +12,9 @@ assert.equal(util.inspect(function() {}), '[Function]');
 assert.equal(util.inspect(undefined), 'undefined');
 assert.equal(util.inspect(null), 'null');
 assert.equal(util.inspect(/foo(bar\n)?/gi), '/foo(bar\\n)?/gi');
-assert.equal(util.inspect(new Date('Sun, 14 Feb 2010 11:48:40 GMT')),
+assert.strictEqual(util.inspect(new Date('Sun, 14 Feb 2010 11:48:40 GMT')),
   new Date('2010-02-14T12:48:40+01:00').toISOString());
+assert.strictEqual(util.inspect(new Date('')), (new Date('')).toString());
 
 assert.equal(util.inspect('\n\u0001'), "'\\n\\u0001'");
 

Original file line number	Diff line number	Diff line change
`@@ -348,7 +348,11 @@ function formatValue(ctx, value, recurseTimes) {`
`348`	`348`	`return ctx.stylize(RegExp.prototype.toString.call(value), 'regexp');`
`349`	`349`	`}`
`350`	`350`	`if (isDate(value)) {`
`351`		`- return ctx.stylize(Date.prototype.toISOString.call(value), 'date');`
	`351`	`+ if (Number.isNaN(value.getTime())) {`
	`352`	`+ return ctx.stylize(value.toString(), 'date');`
	`353`	`+ } else {`
	`354`	`+ return ctx.stylize(Date.prototype.toISOString.call(value), 'date');`
	`355`	`+ }`
`352`	`356`	`}`
`353`	`357`	`if (isError(value)) {`
`354`	`358`	`return formatError(value);`