src: check return value of HMAC_Final

tniessen · danielleadams · commit 5eaa59159fe2 · 2022-04-23T22:47:17.000-04:00
PR-URL: #42303 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
diff --git a/src/crypto/crypto_hmac.cc b/src/crypto/crypto_hmac.cc
@@ -124,8 +124,11 @@ void Hmac::HmacDigest(const FunctionCallbackInfo<Value>& args) {
   unsigned int md_len = 0;
 
   if (hmac->ctx_) {
-    HMAC_Final(hmac->ctx_.get(), md_value, &md_len);
+    bool ok = HMAC_Final(hmac->ctx_.get(), md_value, &md_len);
     hmac->ctx_.reset();
+    if (!ok) {
+      return ThrowCryptoError(env, ERR_get_error(), "Failed to finalize HMAC");
+    }
   }
 
   Local<Value> error;
