crypto: return the retval of HMAC_Update

tmeisenh · sam-github · commit 5ea98fb17d45 · 2017-01-24T14:26:22.000-08:00
Fixes coverity scan issue 55489. PR-URL: #10891 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -3690,8 +3690,8 @@ void Hmac::HmacInit(const FunctionCallbackInfo<Value>& args) {
 bool Hmac::HmacUpdate(const char* data, int len) {
   if (!initialised_)
     return false;
-  HMAC_Update(&ctx_, reinterpret_cast<const unsigned char*>(data), len);
-  return true;
+  int r = HMAC_Update(&ctx_, reinterpret_cast<const unsigned char*>(data), len);
+  return r == 1;
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -3690,8 +3690,8 @@ void Hmac::HmacInit(const FunctionCallbackInfo<Value>& args) {`
`3690`	`3690`	`bool Hmac::HmacUpdate(const char* data, int len) {`
`3691`	`3691`	`if (!initialised_)`
`3692`	`3692`	`return false;`
`3693`		`- HMAC_Update(&ctx_, reinterpret_cast<const unsigned char*>(data), len);`
`3694`		`- return true;`
	`3693`	`+ int r = HMAC_Update(&ctx_, reinterpret_cast<const unsigned char*>(data), len);`
	`3694`	`+ return r == 1;`
`3695`	`3695`	`}`
`3696`	`3696`
`3697`	`3697`