perf_hooks: make Performance extend EventTarget

targos · targos · commit 5d4fc63eb893 · 2021-03-08T20:34:40.000+01:00
Refs: https://www.w3.org/TR/hr-time/#sec-performance PR-URL: #37621 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/perf_hooks.js b/lib/perf_hooks.js
@@ -12,6 +12,10 @@ const {
   constants,
 } = internalBinding('performance');
 
+const {
+  EventTarget,
+} = require('internal/event_target');
+
 const {
   PerformanceEntry,
   now,
@@ -36,7 +40,7 @@ const timerify = require('internal/perf/timerify');
 const { customInspectSymbol: kInspect } = require('internal/util');
 const { inspect } = require('util');
 
-class Performance {
+class Performance extends EventTarget {
   constructor() {
     // eslint-disable-next-line no-restricted-syntax
     throw new TypeError('Illegal constructor');
@@ -57,7 +61,7 @@ class Performance {
   }
 }
 
-class InternalPerformance {}
+class InternalPerformance extends EventTarget {}
 InternalPerformance.prototype.constructor = Performance.prototype.constructor;
 ObjectSetPrototypeOf(InternalPerformance.prototype, Performance.prototype);
 
diff --git a/test/wpt/status/hr-time.json b/test/wpt/status/hr-time.json
@@ -1,7 +1,4 @@
 {
-  "basic.any.js": {
-    "fail": "self.performance.addEventListener is not a function"
-  },
   "idlharness.any.js": {
     "skip": "TODO: update IDL parser"
   },

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,4 @@`
`1`	`1`	`{`
`2`		`- "basic.any.js": {`
`3`		`- "fail": "self.performance.addEventListener is not a function"`
`4`		`- },`
`5`	`2`	`"idlharness.any.js": {`
`6`	`3`	`"skip": "TODO: update IDL parser"`
`7`	`4`	`},`