quic: cleanup timers if they haven't been already

jasnell · jasnell · commit 5a87e9b0a583 · 2020-07-05T14:17:39.000-07:00
PR-URL: #34160 Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/quic/node_quic_session.cc b/src/quic/node_quic_session.cc
@@ -1468,6 +1468,13 @@ QuicSession::~QuicSession() {
   if (listener_ == listener())
     RemoveListener(listener_);
 
+  // Stop and free the idle and retransmission timers if they are active.
+  // In a clean shutdown, using Close(), these will have already been
+  // stopped, but if Close() was not called and we're being destroyed
+  // in GC, for instance, we need to make sure they get stopped here.
+  StopIdleTimer();
+  StopRetransmitTimer();
+
   DebugStats();
 }
 
