deps: fix V8 build on Windows with MSVC

targos · nodejs-github-bot · commit 56c436533eee · 2022-11-27T17:27:19.000Z
PR-URL: #45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/common.gypi b/common.gypi
@@ -36,7 +36,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.3',
+    'v8_embedder_string': '-node.4',
 
     ##### V8 defaults for Node.js #####
 
diff --git a/deps/v8/src/wasm/function-body-decoder-impl.h b/deps/v8/src/wasm/function-body-decoder-impl.h
@@ -2290,7 +2290,7 @@ class WasmDecoder : public Decoder {
   }
 
   // TODO(clemensb): This is only used by the interpreter; move there.
-  V8_EXPORT_PRIVATE std::pair<uint32_t, uint32_t> StackEffect(const byte* pc) {
+  std::pair<uint32_t, uint32_t> StackEffect(const byte* pc) {
     WasmOpcode opcode = static_cast<WasmOpcode>(*pc);
     // Handle "simple" opcodes with a fixed signature first.
     const FunctionSig* sig = WasmOpcodes::Signature(opcode);

Original file line number	Diff line number	Diff line change
`@@ -2290,7 +2290,7 @@ class WasmDecoder : public Decoder {`
`2290`	`2290`	`}`
`2291`	`2291`
`2292`	`2292`	`// TODO(clemensb): This is only used by the interpreter; move there.`
`2293`		`- V8_EXPORT_PRIVATE std::pair<uint32_t, uint32_t> StackEffect(const byte* pc) {`
	`2293`	`+ std::pair<uint32_t, uint32_t> StackEffect(const byte* pc) {`
`2294`	`2294`	`WasmOpcode opcode = static_cast<WasmOpcode>(*pc);`
`2295`	`2295`	`// Handle "simple" opcodes with a fixed signature first.`
`2296`	`2296`	`const FunctionSig* sig = WasmOpcodes::Signature(opcode);`