console: add Symbol.toStringTag property

Leko · Leko · commit 4a6005c56acc · 2020-10-01T23:52:08.000+08:00
Add Symbol.toStringTag property to console object to follow WPT changes Update WPT status of console and the repl test case Refs: web-platform-tests/wpt#24717 PR-URL: #35399 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -19,6 +19,7 @@ const {
   ReflectOwnKeys,
   Symbol,
   SymbolHasInstance,
+  SymbolToStringTag,
   WeakMap,
 } = primordials;
 
@@ -233,6 +234,12 @@ ObjectDefineProperties(Console.prototype, {
           ...consolePropAttributes,
           value: groupIndentation
         },
+        [SymbolToStringTag]: {
+          writable: false,
+          enumerable: false,
+          configurable: true,
+          value: 'console'
+        }
       });
     }
   },
diff --git a/test/parallel/test-repl.js b/test/parallel/test-repl.js
@@ -757,7 +757,7 @@ const errorTests = [
   {
     send: 'console',
     expect: [
-      '{',
+      'Object [console] {',
       '  log: [Function: log],',
       '  warn: [Function: warn],',
       '  dir: [Function: dir],',
diff --git a/test/wpt/status/console.json b/test/wpt/status/console.json
@@ -1,8 +1,5 @@
 {
   "idlharness.any.js": {
     "fail": ".table, .dir and .timeLog parameter lengths are wrong"
-  },
-  "console-namespace-object-class-string.any.js": {
-    "fail": "TODO: https://github.com/web-platform-tests/wpt/pull/24717"
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -757,7 +757,7 @@ const errorTests = [`
`757`	`757`	`{`
`758`	`758`	`send: 'console',`
`759`	`759`	`expect: [`
`760`		`- '{',`
	`760`	`+ 'Object [console] {',`
`761`	`761`	`' log: [Function: log],',`
`762`	`762`	`' warn: [Function: warn],',`
`763`	`763`	`' dir: [Function: dir],',`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"idlharness.any.js": {`
`3`	`3`	`"fail": ".table, .dir and .timeLog parameter lengths are wrong"`
`4`		`- },`
`5`		`- "console-namespace-object-class-string.any.js": {`
`6`		`- "fail": "TODO: https://github.com/web-platform-tests/wpt/pull/24717"`
`7`	`4`	`}`
`8`	`5`	`}`