errors: remove dead code in ERR_INVALID_ARG_TYPE

Flarna · MylesBorins · commit 4981f9721a54 · 2020-01-16T01:43:42.000-05:00
Remove unreachable code. As expected is converted to an Array the 'not ' check will be never executed. PR-URL: #31322 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -946,14 +946,7 @@ E('ERR_INVALID_ARG_TYPE',
       const type = name.includes('.') ? 'property' : 'argument';
       msg += `"${name}" ${type} `;
     }
-
-    // determiner: 'must be' or 'must not be'
-    if (typeof expected === 'string' && expected.startsWith('not ')) {
-      msg += 'must not be ';
-      expected = expected.replace(/^not /, '');
-    } else {
-      msg += 'must be ';
-    }
+    msg += 'must be ';
 
     const types = [];
     const instances = [];
