timers: remove unused repeat param in timer_wrap

jscissr · cjihrig · commit 453514979474 · 2016-08-10T13:03:45.000-04:00
The `repeat` param in `start(timeout, repeat)` was 0 in all callsites. PR-URL: #7994 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/timers.js b/lib/timers.js
@@ -135,7 +135,7 @@ function insert(item, unrefed) {
     list._timer._list = list;
 
     if (unrefed === true) list._timer.unref();
-    list._timer.start(msecs, 0);
+    list._timer.start(msecs);
 
     lists[msecs] = list;
     list._timer[kOnTimeout] = listOnTimeout;
@@ -173,7 +173,7 @@ function listOnTimeout() {
       if (timeRemaining < 0) {
         timeRemaining = 0;
       }
-      this.start(timeRemaining, 0);
+      this.start(timeRemaining);
       debug('%d list wait because diff is %d', msecs, diff);
       return;
     }
@@ -430,7 +430,7 @@ exports.setInterval = function(callback, repeat) {
 
     // If timer is unref'd (or was - it's permanently removed from the list.)
     if (this._handle) {
-      this._handle.start(repeat, 0);
+      this._handle.start(repeat);
     } else {
       timer._idleTimeout = repeat;
       active(timer);
@@ -485,7 +485,7 @@ Timeout.prototype.unref = function() {
     this._handle = handle || new TimerWrap();
     this._handle.owner = this;
     this._handle[kOnTimeout] = unrefdHandle;
-    this._handle.start(delay, 0);
+    this._handle.start(delay);
     this._handle.domain = this.domain;
     this._handle.unref();
   }
diff --git a/src/timer_wrap.cc b/src/timer_wrap.cc
@@ -74,8 +74,7 @@ class TimerWrap : public HandleWrap {
     CHECK(HandleWrap::IsAlive(wrap));
 
     int64_t timeout = args[0]->IntegerValue();
-    int64_t repeat = args[1]->IntegerValue();
-    int err = uv_timer_start(&wrap->handle_, OnTimeout, timeout, repeat);
+    int err = uv_timer_start(&wrap->handle_, OnTimeout, timeout, 0);
     args.GetReturnValue().Set(err);
   }
 
diff --git a/test/pummel/test-timer-wrap.js b/test/pummel/test-timer-wrap.js
@@ -6,7 +6,7 @@ var kOnTimeout = Timer.kOnTimeout;
 
 var t = new Timer();
 
-t.start(1000, 0);
+t.start(1000);
 
 t[kOnTimeout] = common.mustCall(function() {
   console.log('timeout');
diff --git a/test/timers/test-timers-reliability.js b/test/timers/test-timers-reliability.js
@@ -42,7 +42,7 @@ monoTimer[Timer.kOnTimeout] = function() {
   assert(intervalFired);
 };
 
-monoTimer.start(300, 0);
+monoTimer.start(300);
 
 setTimeout(function() {
   timerFired = true;

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,7 @@ class TimerWrap : public HandleWrap {`
`74`	`74`	`CHECK(HandleWrap::IsAlive(wrap));`
`75`	`75`
`76`	`76`	`int64_t timeout = args[0]->IntegerValue();`
`77`		`- int64_t repeat = args[1]->IntegerValue();`
`78`		`- int err = uv_timer_start(&wrap->handle_, OnTimeout, timeout, repeat);`
	`77`	`+ int err = uv_timer_start(&wrap->handle_, OnTimeout, timeout, 0);`
`79`	`78`	`args.GetReturnValue().Set(err);`
`80`	`79`	`}`
`81`	`80`